VMware Logo Update #2377
Merged
VMware Logo Update #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravosuse
approved these changes
Feb 29, 2024
dottorblaster
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
@jagabomb actually this is not tested visually, existing Jest tests cover your patch and we have storybook stories that you attached as a screenshot 👍 😄
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the existing VMware logo with a more recognisable brand-like version. There are also some minor alignment changes here to fix the vertical alignment between the logo and the label which were noted by @arbulu89 in the review. All elements should now be aligned vertically to the center. Please refer to screenshot for a reference of the changes, the old version is on the left and the changes are on the right.
How was this tested?
Visually