Add a scheduled software updates discovery job #2376
Conversation
nelsonkopliku
added
enhancement
nelsonkopliku
force-pushed
the
suma-discovery-watcher
branch
6 times, most recently
from
0d30751 to
2afc779
Compare
nelsonkopliku
force-pushed
the
suma-discovery-watcher
branch
from
2afc779 to
39726f6
Compare
nelsonkopliku
force-pushed
the
suma-discovery-watcher
branch
from
98654d7 to
dcf5f14
Compare
| def discover_software_updates, | ||
| do: | ||
| {:ok, | ||
| Hosts.get_all_hosts() | ||
| |> Enum.map(&discover_host_software_updates/1) | ||
| |> Enum.split_with(fn | ||
| {:ok, _, :discovered, _, _} -> true | ||
| _ -> false | ||
| end)} |
There was a problem hiding this comment.
Can't you just return [] over an erroring discovery? you can keep the logging and you just have to Enum.flatten this list instead of playing with tagged tuples.
There was a problem hiding this comment.
When testing I want to rely on the output of the function, rather than logging 😅 That's the reason behind it.
We could alternatively return just one list with all the discovery results, successful and errored. However we'd need to do filtering of successful vs errored results in the test to make meaningful assertions. We get that distinction for free by splitting here. I find it convenient.
I simplified a bit the tuple returned in success case from {:ok, host_id, :discovered, system_id, relevant_patches} to {:ok, host_id, system_id, relevant_patches} 👍
Description
This PR adds the capability to discover software updates for all the registered hosts in trento.
This has been scheduled to happen every 12 hours.
How was this tested?
Automated tests.