-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change host's health based on software updates discovery result #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
force-pushed
the
suma-based-host-health-change
branch
2 times, most recently
from
February 28, 2024 15:20
daf1103
to
3bc128f
Compare
nelsonkopliku
added
enhancement
New feature or request
user story
elixir
Pull requests that update Elixir code
labels
Feb 28, 2024
nelsonkopliku
force-pushed
the
suma-based-host-health-change
branch
from
February 29, 2024 08:41
3bc128f
to
fe8815d
Compare
jamie-suse
reviewed
Feb 29, 2024
dottorblaster
suggested changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny change request, I think it would simplify the tests as well, let me know what do you think. Great job, keep it up!
nelsonkopliku
force-pushed
the
suma-based-host-health-change
branch
from
February 29, 2024 11:40
fe8815d
to
bf6e275
Compare
dottorblaster
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jamie-suse
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the domain logic to handle software updates discovery.
SoftwareUpdatesDiscoveryCompleted
is emitted containing the discovered relevant patches counts. Needed to properly update aggregate state and opens the possibility to project such data if needed and to possibly broadcast via websockets interesting information that might be useful for the UX.HostHealthChanged
event might be emittedI think we might need extra domain interactions related to software updates discovery business process that would allow us to answer the following:
How was this tested?
Automated tests added.