Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saptune domain clause #1975

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix saptune domain clause #1975

merged 1 commit into from
Nov 6, 2023

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Nov 6, 2023

Description

Stupid mistake in the clause...
It was causing an error in a pretty standard scenario, as it was passing the saptune status, instead of the expected host domain state:

09:08:39.533 [error] ** (FunctionClauseError) no function clause matching in Trento.Domain.Host.maybe_emit_host_saptune_health_changed_event/2
    (trento 2.1.0-git.dev273.1698996215.8d6c8aa7) lib/trento/domain/host/host.ex:686: Trento.Domain.Host.maybe_emit_host_saptune_health_changed_event(%Trento.Domain.SaptuneStatus{applied_notes: [], applied_solution: nil, configured_version: nil, enabled_notes: [], enabled_solution: nil, package_version: "3.0.2", services: [], staging: nil, tuning_state: nil}, true)

How was this tested?

New UT added. The unique lines that were not tested causes the error, murphy's law XD

@arbulu89 arbulu89 added the bug Something isn't working label Nov 6, 2023
@arbulu89 arbulu89 force-pushed the fix-saptune-domain-clause branch from 9f56f95 to 9388636 Compare November 6, 2023 09:38
@arbulu89 arbulu89 marked this pull request as ready for review November 6, 2023 09:48
@arbulu89 arbulu89 merged commit 7579b18 into main Nov 6, 2023
24 checks passed
@arbulu89 arbulu89 deleted the fix-saptune-domain-clause branch November 6, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

5 participants