Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3 categories for Storybook structure #1918

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

jagabomb
Copy link
Contributor

Description

This PR attempts to create some structure in Storybook. It introduces three categories: Components, Patterns (placeholder title for now) and Layouts. These categories will group components based on the amount of elements creating each component. Similarly to the Atomic Design approach we are using Components as or smallest element, then we have Patterns which consist of a group of Components and lastly we have the biggest being Layouts which are a combination of Patterns and Components.

By having these categories it will help to quickly identify outstanding components, and which stories are related to page layouts for example.

Fixes # (issue)
A growing list of unorganised components.

How was this tested?

Visually

Screenshot 2023-10-11 at 13 11 55

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES.

I was thinking the same some weeks ago, then I totally forgot about that. I like it.

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey what a nice change :D LGTM!

@jagabomb jagabomb merged commit 3a2104e into main Oct 11, 2023
40 checks passed
@jagabomb jagabomb deleted the storybook_structure_naming branch October 11, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants