Improve renderSolution function if solution is empty #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
reviewed
Oct 9, 2023
EMaksy
force-pushed
the
saptune_details_view_render_solution_fix
branch
2 times, most recently
from
15b0440 to
aac5c6f
Compare
arbulu89
reviewed
Oct 9, 2023
EMaksy
force-pushed
the
saptune_details_view_render_solution_fix
branch
2 times, most recently
from
3bf9c1e to
44f15af
Compare
arbulu89
requested changes
Oct 10, 2023
| @@ -110,4 +110,54 @@ describe('SaptuneDetails', () => { | |||
| staging.solutions_ids | |||
| ); | |||
| }); | |||
|
|
|||
| it.each([ | |||
| { solution: null }, | |||
There was a problem hiding this comment.
why all of this strange things?
Except the null option the other 2 are not real cases. They won't happen, so we don't need to test them.
There was a problem hiding this comment.
Fair enough, the other cases are irrelevant, i just thought some extra error testing won't harm :D
| enabledSolution={solution} | ||
| hostname={hostname} | ||
| hostID={hostID} | ||
| configuredVersion={configuredVersion} |
There was a problem hiding this comment.
Send enabledNotes and appliedNotes as empty lists and check we display them as "empty"
EMaksy
force-pushed
the
saptune_details_view_render_solution_fix
branch
2 times, most recently
from
7d8c54a to
560c5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A quick fix to ensure that SaptuneDetails is rendered properly if solutions are empty
If solution is empty then applied and enabled solution will render '-'
Demo
How was this tested?
Added automated test