Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated Agent message #1883

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

stefanotorresi
Copy link
Member

@stefanotorresi stefanotorresi commented Sep 28, 2023

Description

Updates a hard coded frontend warning message.

Did you add the right label?

Trivial UX enhancement.

How was this tested?

Automated JS frontend tests.

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let this @abravosuse @jagabomb

@abravosuse
Copy link
Contributor

For me it is OK.

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the wording is validated we can merge 👍

(of course when the CI is green)

@arbulu89
Copy link
Contributor

arbulu89 commented Oct 2, 2023

@stefanotorresi You need to update the test if you want this PR merged 🙈

@stefanotorresi stefanotorresi force-pushed the stefanotorresi-outdated-agent-message branch from d0c39de to 584dda5 Compare October 6, 2023 11:31
@stefanotorresi stefanotorresi merged commit 290a5b2 into main Oct 6, 2023
24 checks passed
@stefanotorresi stefanotorresi deleted the stefanotorresi-outdated-agent-message branch October 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Development

Successfully merging this pull request may close these issues.

4 participants