Handle fact value with null value #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
rtorrero,
CDimonaco and
EMaksy
arbulu89
commented
Sep 27, 2023
| @@ -46,6 +46,10 @@ export const treeify = (name, data) => ({ | |||
| const { [key]: element } = data; | |||
| const dataType = typeof element; | |||
|
|
|||
| if (element == null) { | |||
There was a problem hiding this comment.
This is the piece of code which fixes the actual error
arbulu89
force-pushed
the
object-tree-render-null
branch
from
5f68c24 to
cc67448
Compare
nelsonkopliku
approved these changes
Sep 27, 2023
| ) : ( | ||
| <span className={className}>{`${data}`}</span> | ||
| ); | ||
| if (data === null) { |
There was a problem hiding this comment.
Just curious, this is needed because typeof null is object, right? 😄
Besides this I am wondering whether it would make sense having this check in ObjectTree itself. wdyt?
There was a problem hiding this comment.
Just curious, this is needed because typeof null is object, right? 😄
Yes, it is a bug in js that it won't be fixed in 10000 years.
Besides this I am wondering whether it would make sense having this check in ObjectTree itself. wdyt?
We have the same fix in the ObjectTree. We need to have in both places because we can get a plain fact value, so we don't always use ObjectTree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle
nullvalue in theObjectTree. Without this fix theObject.keys(data)above panics.Related to: trento-project/wanda#297
PD: As the objectree treats arrays and objects as the same, I think having the
{}is good enough.How was this tested?
UT added