Instance cleanup e2e #1783
Merged
Instance cleanup e2e #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
instance-cleanup-e2e
branch
from
79b0cfd to
55cba16
Compare
rtorrero
approved these changes
Sep 7, 2023
.photofinish.toml
Outdated
| @@ -291,4 +288,40 @@ files = [ | |||
| "./test/fixtures/scenarios/healthy-27-node-SAP-cluster/0a055c90-4cb6-54ce-ac9c-ae3fedaf40d4_host_discovery.json", | |||
| "./test/fixtures/scenarios/healthy-27-node-SAP-cluster/0a055c90-4cb6-54ce-ac9c-ae3fedaf40d4_sap_system_discovery.json", | |||
| "./test/fixtures/scenarios/healthy-27-node-SAP-cluster/0a055c90-4cb6-54ce-ac9c-ae3fedaf40d4_subscription_discovery.json", | |||
| ] | |||
|
|
|||
| [NWD-00-present] | |||
There was a problem hiding this comment.
I've noticed we usually start these with sapsystem- or database- or host-... depending on what we are pushing. In this case it's obvious but I'd add it to keep the good habit I guess :-)
| cy.get('table.table-fixed > tbody > tr').eq(0).click(); | ||
| }); | ||
|
|
||
| it('should mark an instance as absent and restore it as present', () => { |
There was a problem hiding this comment.
I'm missing a "when" or an "after" to describe the condition
arbulu89
force-pushed
the
instance-cleanup-e2e
branch
from
5d1f350 to
8b45a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E2E tests for the instance deregistration feature.