Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rowKey function for table rows #1781

Merged
merged 2 commits into from
Sep 4, 2023
Merged

rowKey function for table rows #1781

merged 2 commits into from
Sep 4, 2023

Conversation

dottorblaster
Copy link
Contributor

Description

We need to have a function inside the table component to determine the key for a row in a flexible way

How was this tested?

Jest tests

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Most probably we want to use this function now in all of our tables.
Right?
To avoid the bad practice of the index usage.
By now, I'll at least use it in the place where it creates undesared behaviours.

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dottorblaster dottorblaster merged commit afacda5 into main Sep 4, 2023
@dottorblaster dottorblaster deleted the row-key-table branch September 4, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants