Add absent_at field to projectors and broadcast events
#1775
Conversation
| @@ -97,6 +97,21 @@ defmodule TrentoWeb.V1.SapSystemView do | |||
|
|
|||
| def render("application_instance_health_changed.json", %{health: health}), do: health | |||
|
|
|||
| def render("instance_absent_at_changed.json", %{ | |||
There was a problem hiding this comment.
I would follow the same pattern we use in others and wrap the data in a instance field, like what we do in database_instance_health_changed.json and database_instance_system_replication_changed.json"
| @@ -97,6 +97,21 @@ defmodule TrentoWeb.V1.SapSystemView do | |||
|
|
|||
| def render("application_instance_health_changed.json", %{health: health}), do: health | |||
|
|
|||
| def render("instance_absent_at_changed.json", %{ | |||
There was a problem hiding this comment.
Let's put this function at the end, just after def render("instance_deregistered.json", %{
| @@ -295,6 +297,67 @@ defmodule Trento.DatabaseProjectorTest do | |||
| 1000 | |||
| end | |||
|
|
|||
| test "should broadcast database_instance_absent_at_changed when DatabaseInstanceMarkedAbsent event is received" do | |||
There was a problem hiding this comment.
The main things under test is the projection, not the broadcasting.
Let's change the test text to:
should update the absent_at field on DatabaseInstanceMarkedAbsent event is received.
The same for others
| instance_number: instance_number, | ||
| host_id: host_id, | ||
| sid: sid | ||
| } = insert(:database_instance_without_host) |
There was a problem hiding this comment.
Let's put some value to absent_at first:
insert(:database_instance_without_host, absent_at: DateTime.utc_now())
| @@ -213,6 +215,85 @@ defmodule Trento.SapSystemProjectorTest do | |||
| ) | |||
| end | |||
|
|
|||
| test "should broadcast application_instance_absent_at_changed when ApplicationInstanceMarkedAbsent event is received" do | |||
| insert(:sap_system, id: sap_system_id = Faker.UUID.v4()) | |||
There was a problem hiding this comment.
%{id: sap_system_id} = insert(:sap_system)
|
|
||
| ProjectorTestHelper.project(SapSystemProjector, event, "sap_system_projector") | ||
|
|
||
| %{ |
There was a problem hiding this comment.
This doesn't make sense. You already get this information from the factory, you don't need to re-query.
You can "copy/paste" what you did in the database projection tests
| @@ -213,6 +215,85 @@ defmodule Trento.SapSystemProjectorTest do | |||
| ) | |||
| end | |||
|
|
|||
| test "should broadcast application_instance_absent_at_changed when ApplicationInstanceMarkedAbsent event is received" do | |||
| insert(:sap_system, id: sap_system_id = Faker.UUID.v4()) | |||
| event = build(:application_instance_registered_event, sap_system_id: sap_system_id) | |||
There was a problem hiding this comment.
You don't need this event, right?
| @@ -295,6 +297,67 @@ defmodule Trento.DatabaseProjectorTest do | |||
| 1000 | |||
| end | |||
|
|
|||
| test "should update the absent_at field on DatabaseInstanceMarkedAbsent event is received" do | |||
There was a problem hiding this comment.
it looks like we should replace on by when, right?
Description
This change makes the SAP system and database projectors listen to the
*MarkedAsAbsent/*MarkedAsPresentevents, whereupon they update the read models and broadcast this change through the websocket channel as events namedapplication_instance_absent_at_changed/database_instance_absent_at_changedHow was this tested?
Added unit tests for the new behaviour in the projectors