Refactor sap system selectors #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
commented
Aug 28, 2023
| @@ -24,6 +24,11 @@ export const getClusterName = (clusterID) => (state) => { | |||
| return get(cluster, 'name', ''); | |||
| }; | |||
|
|
|||
| export const getClusterByHost = (state, hostID) => { | |||
There was a problem hiding this comment.
Moved from index.js. Now it uses lodash find function
| [ | ||
| (id, state) => getSapSystem(id)(state), | ||
| (id, state) => | ||
| enrichInstances( |
There was a problem hiding this comment.
I'm not sure if adding this operation here is a good idea, or it should better go in the body of the function
arbulu89
commented
Aug 28, 2023
| export const getDatabase = (id) => (state) => | ||
| state.databasesList.databases.find((database) => id === database.id); | ||
|
|
||
| export const getEnrichedSapSystemDetails = createSelector( |
There was a problem hiding this comment.
In essence, the next getEnrichedSapSystemDetails and getEnrichedDatabaseDetails functions have been the major change in the whole PR.
dottorblaster
suggested changes
Aug 28, 2023
Comment on lines
45
to
46
| (id, state) => getSapSystem(id)(state), | ||
| (id, state) => |
There was a problem hiding this comment.
Can you switch this to (state, id) form? Usually state comes as the first parameter when you use createSelector
There was a problem hiding this comment.
I can and I will!
Thank you for the tip
arbulu89
force-pushed
the
refactor-sap-system-selectors
branch
from
5b15778 to
d5ba3fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor sap systems/databases selectors to use
createSelector. This will enable to update SapSystemsOverview and DatabasesOverview views to make storybook addition easy.Besides that, I have moved the functions to a new
sapSystemsfile, used lodash in some operations and removed the camelCase transformation that is only used in these selectors.How was this tested?
Tests added after refactoring