Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wanda demo to pr env #1707

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add wanda demo to pr env #1707

merged 2 commits into from
Aug 21, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Aug 10, 2023

Description

With this little change we have also the possibility to interact with checks execution.

https://1707.prenv.trento.suse.com/


Besides this also a specific rabbit user for the PR has been specified, otherwise different PRs interfere with each other with the default user being deleted.

@nelsonkopliku nelsonkopliku self-assigned this Aug 10, 2023
@nelsonkopliku nelsonkopliku added env Create an ephimeral environment for the pr branch enhancement New feature or request labels Aug 10, 2023
@nelsonkopliku nelsonkopliku marked this pull request as ready for review August 10, 2023 10:06
@nelsonkopliku nelsonkopliku marked this pull request as draft August 10, 2023 10:08
@nelsonkopliku nelsonkopliku force-pushed the add-wanda-demo-to-pr-env branch from 63b6034 to 45e64be Compare August 10, 2023 10:48
@nelsonkopliku nelsonkopliku marked this pull request as ready for review August 10, 2023 11:01
@nelsonkopliku nelsonkopliku force-pushed the add-wanda-demo-to-pr-env branch 2 times, most recently from 83c9c91 to bb9786e Compare August 10, 2023 11:04
@abravosuse
Copy link
Contributor

What should I be looking at here @nelsonkopliku ?

@nelsonkopliku
Copy link
Member Author

nelsonkopliku commented Aug 10, 2023

What should I be looking at here @nelsonkopliku ?

That the checks execution at https://1707.prenv.trento.suse.com/ works. Previously it always timed out because there are no agents returning gathered facts.

Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code apart, it looks good to me.

@nelsonkopliku nelsonkopliku requested a review from arbulu89 August 21, 2023 10:22
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @nelsonkopliku

PD: Not your fault, and not need to add any change (as it was already this way), but not having any space before the ending }} make my eyes bleed XD

.github/workflows/pr_env.yaml Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku force-pushed the add-wanda-demo-to-pr-env branch from bb9786e to a40ba4c Compare August 21, 2023 10:53
@nelsonkopliku
Copy link
Member Author

Thanks @arbulu89 for the review.
I don't wanto to see your eyes bleeding 😂 , so here's the commit fixing the interpolation a40ba4c

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nelsonkopliku nelsonkopliku merged commit 296d191 into main Aug 21, 2023
@nelsonkopliku nelsonkopliku deleted the add-wanda-demo-to-pr-env branch August 21, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request env Create an ephimeral environment for the pr branch
Development

Successfully merging this pull request may close these issues.

3 participants