Fix sles subscriptions count #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
force-pushed
the
fix_sles_subscriptions_count
branch
from
f3d1f48 to
39aeffb
Compare
nelsonkopliku
force-pushed
the
fix_sles_subscriptions_count
branch
from
39aeffb to
4710b4b
Compare
| {:error, _} -> | ||
| conn | ||
| |> put_status(:internal_server_error) | ||
| |> json(%{error: "An error occurred in retrieving SLES subscription count."}) |
There was a problem hiding this comment.
thanks, but unnecessary 😄
| subscription_projection(identifier: "sle-module-server-applications") | ||
| end) | ||
|
|
||
| assert 12 = Repo.all(SlesSubscriptionReadModel) |> length() |
There was a problem hiding this comment.
Suggested change
| assert 12 = Repo.all(SlesSubscriptionReadModel) |> length() | |
| assert 12 = SlesSubscriptionReadModel |> Repo.all() |> length() |
lib/tronto/monitoring/monitoring.ex
Outdated
|
|
||
| case Repo.one(query) do | ||
| {:error, _} = error -> | ||
| error |
There was a problem hiding this comment.
Repo.one returns nil or the entity, this case will never match
fabriziosestito
suggested changes
Mar 14, 2022
nelsonkopliku
force-pushed
the
fix_sles_subscriptions_count
branch
from
f3cd26b to
c507e9a
Compare
fabriziosestito
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports this
to tronto in order to properly count sles subscriptions.
Thanks again photofinish 😄