Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use centralized checks selection for both hosts and clusters #1641

Merged
merged 9 commits into from
Jul 19, 2023
Merged

Use centralized checks selection for both hosts and clusters #1641

merged 9 commits into from
Jul 19, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Jul 18, 2023 •
edited
Loading

Description

This PR:

  • adds the cluster checks selection saga in the centralized checks selection saga
  • makes the new centralized checks selection used both in host and cluster checks selection pages.
  • cleans up legacy

Note that the changes in the legacy assets/js/components/ClusterDetails/ChecksSelection.jsx and test are basically transient as that component will be removed soon in favor of the generalized one in assets/js/components/ChecksSelection/ChecksSelection.jsx

How was this tested?

Automated tests.

@nelsonkopliku nelsonkopliku force-pushed the refactor-cluster-checks-selection branch from b593824 to abbbba1 Compare July 18, 2023 13:05
@nelsonkopliku nelsonkopliku self-assigned this Jul 18, 2023
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story chore javascript Pull requests that update Javascript code labels Jul 18, 2023
@nelsonkopliku nelsonkopliku force-pushed the refactor-cluster-checks-selection branch from abbbba1 to bfd22a6 Compare July 18, 2023 13:15
@nelsonkopliku nelsonkopliku marked this pull request as ready for review July 18, 2023 13:16
@nelsonkopliku nelsonkopliku changed the title Refactor cluster checks selection Use centralized checks selection for both hosts and clusters Jul 18, 2023
dottorblaster
dottorblaster suggested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes and then we can merge

assets/js/components/ClusterDetails/ChecksSelection.jsx Outdated Show resolved Hide resolved
assets/js/state/checksSelection.js Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku force-pushed the refactor-cluster-checks-selection branch from 47be8ca to a9ec7ac Compare July 19, 2023 10:18
dottorblaster
dottorblaster approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit 0b511c0 into main Jul 19, 2023
@nelsonkopliku nelsonkopliku deleted the refactor-cluster-checks-selection branch July 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@EMaksy EMaksy Awaiting requested review from EMaksy

Assignees

@nelsonkopliku nelsonkopliku

Labels
chore enhancement New feature or request javascript Pull requests that update Javascript code user story
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonkopliku @dottorblaster