Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing target_type query param to catalog when loading execution results page #1568

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Add missing target_type query param to catalog when loading execution results page #1568

merged 1 commit into from
Jun 23, 2023

Conversation

nelsonkopliku
Copy link
Member

Description

Adds a missing target_type=cluster when loading the execution results page.

@nelsonkopliku nelsonkopliku added bug Something isn't working chore labels Jun 23, 2023
@nelsonkopliku nelsonkopliku self-assigned this Jun 23, 2023
@nelsonkopliku nelsonkopliku marked this pull request as ready for review June 23, 2023 13:56
EMaksy
EMaksy approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@nelsonkopliku nelsonkopliku merged commit f690232 into main Jun 23, 2023
@nelsonkopliku nelsonkopliku deleted the properly-load-catalog-in-execution-results branch June 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMaksy EMaksy EMaksy approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

Assignees

@nelsonkopliku nelsonkopliku

Labels
bug Something isn't working chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonkopliku @EMaksy