Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable check execution button while loading #1503

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Disable check execution button while loading #1503

merged 4 commits into from
Jun 8, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Jun 8, 2023 •
edited
Loading

Description

Disables starting an execution when:

  • the execution is being loaded from wanda so we don't know whether it is running or completed
  • the execution has been requested
  • the execution is running
  • no checks were selected (already there)

image

How was this tested?

Tests and stories added/updated

@nelsonkopliku nelsonkopliku force-pushed the disable_check_execution_button_while_loading branch 3 times, most recently from 9f325fb to 7d24258 Compare June 8, 2023 07:09
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Jun 8, 2023
@nelsonkopliku nelsonkopliku marked this pull request as ready for review June 8, 2023 07:33
dottorblaster
dottorblaster suggested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two tiny changes then we can merge

assets/js/components/ClusterDetails/HanaClusterDetails.jsx Outdated Show resolved Hide resolved
assets/js/state/selectors/lastExecutions.js Outdated Show resolved Hide resolved
dottorblaster
dottorblaster approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku force-pushed the disable_check_execution_button_while_loading branch from d72e92d to 59fe998 Compare June 8, 2023 12:26
@nelsonkopliku nelsonkopliku merged commit 312fc90 into main Jun 8, 2023
@nelsonkopliku nelsonkopliku deleted the disable_check_execution_button_while_loading branch June 8, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@arbulu89 arbulu89 Awaiting requested review from arbulu89

Assignees

@nelsonkopliku nelsonkopliku

@EMaksy EMaksy

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @dottorblaster @EMaksy