Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle evaluation errors #1486

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Handle evaluation errors #1486

merged 3 commits into from
Jun 7, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Jun 5, 2023 •
edited
Loading

Description

This PR fixes a bug that doesn't correctly allow for rendering of evaluation errors (ie. rhai script fails)

Before
image

After
image

Side effect: check 373DB8 needs to be fixed.

How was this tested?

Tests and stories updated.

@nelsonkopliku nelsonkopliku self-assigned this Jun 5, 2023
@nelsonkopliku nelsonkopliku added the bug Something isn't working label Jun 5, 2023
@nelsonkopliku nelsonkopliku force-pushed the handle-evaluation-errors branch 3 times, most recently from e936e13 to 8fc9d68 Compare June 5, 2023 13:00
@nelsonkopliku nelsonkopliku marked this pull request as ready for review June 5, 2023 13:05
abravosuse
abravosuse reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the screenshots, it looks good to me. Is this something that I could review on the Storybook and, if so, where in the Storybook? I'm just trying to familiarize myself with the tool.

Also, you mention that as a side effect check 373DB8 needs to be fixed. Are you engaging the Checks Team for this or is it something that you will address yourself? One way or another we will need, I guess, a ticket and I'm trying to figure out which is the right board for it (ours or the Checks Team's).

arbulu89
arbulu89 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @nelsonkopliku

assets/js/components/ExecutionResults/checksUtils.js Outdated Show resolved Hide resolved
assets/js/lib/test-utils/factories/executions.js Show resolved Hide resolved
@arbulu89
Copy link
Contributor

arbulu89 commented Jun 5, 2023

@abravosuse I couple of new stories where added under the ExpectationResults story.
I don't think you will get many value, as the displayed error message is the same as before for the user, and the content is the story is faked data.

@nelsonkopliku nelsonkopliku force-pushed the handle-evaluation-errors branch 2 times, most recently from 7126dc9 to 85f91c0 Compare June 5, 2023 15:23
@nelsonkopliku nelsonkopliku force-pushed the handle-evaluation-errors branch from 85f91c0 to b82faca Compare June 6, 2023 16:51
dottorblaster
dottorblaster approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wasn't convinced by byName, but you already got that :D

@nelsonkopliku nelsonkopliku merged commit 05f6c4e into main Jun 7, 2023
@nelsonkopliku nelsonkopliku deleted the handle-evaluation-errors branch June 7, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abravosuse abravosuse abravosuse left review comments

@arbulu89 arbulu89 arbulu89 approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@EMaksy EMaksy Awaiting requested review from EMaksy

Assignees

@nelsonkopliku nelsonkopliku

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nelsonkopliku @arbulu89 @dottorblaster @abravosuse