Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCS/ERS cluster details component #1466

Merged
merged 9 commits into from
May 30, 2023
Merged

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented May 29, 2023

Description

Add ASCS/ERS details component.
By now, it excludes the nodes table. I will create other PR with it to make it more manageable to review.

Find story book in the CI executions link below (Storybook publish). In AscsErsClusterDetails section

How was this tested?

Storybook stories and tests

@arbulu89 arbulu89 added the enhancement New feature or request label May 29, 2023
@arbulu89 arbulu89 marked this pull request as ready for review May 29, 2023 11:41
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change then we can merge

@arbulu89 arbulu89 force-pushed the ascs-ers-cluster-component branch from 5862d3a to cfcb087 Compare May 30, 2023 07:07
@arbulu89 arbulu89 assigned abravosuse and unassigned abravosuse May 30, 2023
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@arbulu89 arbulu89 force-pushed the ascs-ers-cluster-component branch from cfcb087 to a3e0224 Compare May 30, 2023 07:16
@arbulu89 arbulu89 merged commit 5f9adcf into main May 30, 2023
@arbulu89 arbulu89 deleted the ascs-ers-cluster-component branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants