Display check failure message

[nelsonkopliku]

Description

This PR adds rendering of a check expectation's failure_message returned by wanda on a failing check.

Took the chance to tidy up a bit factories. More might come as we go.

@jagabomb I went for option 1 in figma just out of personal taste, however let me know if option two should be the way.

How was this tested?

Automated tests/storybook

[abravosuse]

Code apart, that looks awesome to me.

[jagabomb]

@jagabomb I went for option 1 in figma just out of personal taste, however let me know if option two should be the way.

Thanks for this @nelsonkopliku, Option 1 is a good option to proceed with. The only question I have is, is it possible to emphasis certain values in the failing message, like the words Failing and values (3 and 1)?

[nelsonkopliku]

is it possible to emphasis certain values in the failing message, like the words Failing and values (3 and 1)?

@jagabomb I was waiting for this 😄
So, we could make Failing bold/semibold without much hassle, however consider that in the same result there might also be Passing evaluations. What about those?

In regards to highlighting specific parts of the failure message I am afraid that would be trickier.
It would mean making failure_message field exposed by wanda a markdown possibly, which would bring in the problem of interpolation inside a markdown and refactoring all the checks.

Honestly, not an option for me at the moment 😅

[jagabomb]

After thinking of the Passing state, it would not make sense to emphasise the Failing/Passing wording. So let's just scrap my request there.

I was hoping we could do some interpolation on the frontend to take the whatever is within quotations ('') and make those values bold. But if it too much heavy effort for now then lets proceed with the initial PR. 😅

[arbulu89]

@nelsonkopliku Good!
I just proposed some changes in the factory itself.
We don't need to do such a default values handling, fishery is pretty smart with those things.
Don't need a new review anyway

[arbulu89]

Great!

[jagabomb]

Approved as per comments.

[EMaksy]

Hey man nice!
LGTM