Improve scalar values support in FactValue #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
suggested changes
May 16, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
nelsonkopliku
force-pushed
the
fix-fact-value-booleans
branch
from
c7ec2a7 to
70b2b2c
Compare
EMaksy
approved these changes
May 16, 2023
There was a problem hiding this comment.
Besides the comment discussion from @dottorblaster nothing to add.
Very nice improvement :D
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves support for
booleanvalues inFactValuecomponent.Before
After
How was this tested?
Extended tests.