[POC] HANA scale-up e2e tests with a real cluster #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
e2e-gh-actions
branch
from
a87d462 to
c9f3888
Compare
fabriziosestito
force-pushed
the
e2e-gh-actions
branch
2 times, most recently
from
e2be05c to
77fa296
Compare
fabriziosestito
changed the title
fabriziosestito
changed the title
fabriziosestito
force-pushed
the
e2e-gh-actions
branch
from
77fa296 to
36beb6a
Compare
fabriziosestito
requested review from
dottorblaster,
rtorrero,
nelsonkopliku,
CDimonaco,
jamie-suse and
EMaksy
fabriziosestito
commented
Apr 19, 2023
| - name: Checkout terraform repo | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| repository: fabriziosestito/trento-e2e |
There was a problem hiding this comment.
MEMO to self: change to main repo when decided which AMI to use
fabriziosestito
force-pushed
the
e2e-gh-actions
branch
from
36beb6a to
b02762b
Compare
fabriziosestito
force-pushed
the
e2e-gh-actions
branch
from
0ce3822 to
bdf35ac
Compare
arbulu89
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Great job @fabriziosestito
Really valuable
PD: I think unfortunately already got outdated with the latest changes on the trento-ansible project
arbulu89
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a PoC that adds an automated test that spins up a HANA scale-up cluster.
The test involves running checks and comparing the output with the expected results.
It can be used as a base to script other automated tests or scenarios.
It uses Terraform to deploy a real infrastructure on AWS, ansible to deploy trento server and the agents, and cypress to run the e2e tests.
Destroying the infrastructure requires a workaround since the VPC is created with some dependencies that Terraform doesn't seem to be able to manage.
I've added a Cypress env variable to skip photofinish scenario loading at the beginning of the test, and to make the test skippable in the current e2e tests. Maybe in the future we should separate the test folders.
As for now, the action can be triggered by a
workflow_dispatchevent (manually) and only works with the rolling version of trento.In the future, we could consider deploying a specific commit, generalize the version for another scenario, and use composite actions.