Agent version warning #1259
Merged
Agent version warning #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super cool. |
rtorrero
approved these changes
Mar 14, 2023
dottorblaster
suggested changes
Mar 15, 2023
EMaksy
approved these changes
Mar 15, 2023
arbulu89
force-pushed
the
agent-version-warning
branch
from
f206669 to
5bbd532
Compare
arbulu89
force-pushed
the
agent-version-warning
branch
from
5bbd532 to
93443cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include incompatible agent version warning in hosts list and detail views. It includes a new
semverlibrary to do the comparison in the frontend.PD: The usage of the tooltip is super limited right now. We should consider using a well known library for this, like: https://github.com/ReactTooltip/react-tooltip
Otherwise the current component usage doesn't give much space.
PD2: Story book doesn't work in this current
mainbranch. So manual changes must be done. The fix is already done in thenew-checks-uibranch thoughHow was this tested?
Unit tests and storybook stories added