-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix css bugs #1197
Merged
Merged
Fix css bugs #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
force-pushed
the
fix_cluster_datails_css
branch
4 times, most recently
from
February 17, 2023 09:38
72c4b1b
to
4bf3c39
Compare
EMaksy
requested review from
CDimonaco,
arbulu89,
rtorrero,
dottorblaster,
fabriziosestito,
jagabomb,
jamie-suse and
nelsonkopliku
February 17, 2023 09:53
dottorblaster
suggested changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some adjustments to do then if @jagabomb likes that I'm fine 😬
nelsonkopliku
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
dottorblaster
approved these changes
Feb 17, 2023
EMaksy
force-pushed
the
fix_cluster_datails_css
branch
3 times, most recently
from
February 17, 2023 16:17
be07519
to
7420555
Compare
EMaksy
force-pushed
the
fix_cluster_datails_css
branch
from
February 17, 2023 16:20
7420555
to
daa4c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing two existing css bugs.
Cluster Details View
Problem: CTAs in Cluster detail view are not properly aligned
OLD unfixed:
unfixed_cluster_details_view.webm
NEW fixed:
fixed_cluster_details_view.webm
Check Execution view
Problem: In the execution results page, the filter width changes if some values are selected
OLD:
NEW: