Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css bugs #1197

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Fix css bugs #1197

merged 6 commits into from
Feb 17, 2023

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Feb 16, 2023

Description

Fixing two existing css bugs.

Cluster Details View

Problem: CTAs in Cluster detail view are not properly aligned

OLD unfixed:
unfixed_cluster_details_view.webm

NEW fixed:
fixed_cluster_details_view.webm

Check Execution view

Problem: In the execution results page, the filter width changes if some values are selected

OLD:
old_filter

NEW:
fixed_filter_width

@EMaksy EMaksy self-assigned this Feb 16, 2023
@EMaksy EMaksy added the bug Something isn't working label Feb 16, 2023
@EMaksy EMaksy force-pushed the fix_cluster_datails_css branch 4 times, most recently from 72c4b1b to 4bf3c39 Compare February 17, 2023 09:38
@EMaksy EMaksy marked this pull request as ready for review February 17, 2023 09:53
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some adjustments to do then if @jagabomb likes that I'm fine 😬

assets/js/components/ClusterDetails/ClusterDetails.jsx Outdated Show resolved Hide resolved
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@EMaksy EMaksy requested a review from dottorblaster February 17, 2023 12:35
@EMaksy EMaksy force-pushed the fix_cluster_datails_css branch 3 times, most recently from be07519 to 7420555 Compare February 17, 2023 16:17
@EMaksy EMaksy force-pushed the fix_cluster_datails_css branch from 7420555 to daa4c9a Compare February 17, 2023 16:20
@EMaksy EMaksy merged commit 6662a29 into main Feb 17, 2023
@EMaksy EMaksy deleted the fix_cluster_datails_css branch February 17, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants