Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout rendering when not logged-in #1138

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Jan 23, 2023

When accessing a protected page, the layout was rendered for a split second due to the wrong route ordering in the React router.
This PR fixes it.

@fabriziosestito fabriziosestito added the bug Something isn't working label Jan 23, 2023
@fabriziosestito fabriziosestito marked this pull request as ready for review January 23, 2023 18:27
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziosestito fabriziosestito merged commit 8640705 into main Jan 24, 2023
@fabriziosestito fabriziosestito deleted the fix-layout-route-order branch January 24, 2023 07:39
rtorrero pushed a commit to rtorrero/web that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants