Allow getCatalog wanda call to filter by provider #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
added
enhancement
dottorblaster
suggested changes
Jan 11, 2023
There was a problem hiding this comment.
Overall a good job, I made some suggestions so that we end basically collecting an env object that we end up passing to the request. I'm uncertain about the suggestion I made on assets/js/state/actions/catalog.js because actually having a RORO there would ensure some extra parsing.
Ref about RORO: https://www.freecodecamp.org/news/elegant-patterns-in-modern-javascript-roro-be01e7669cbd/
rtorrero
force-pushed
the
add-catalog-filtering-per-provider
branch
from
0c1ac6c to
c350f26
Compare
rtorrero
force-pushed
the
add-catalog-filtering-per-provider
branch
from
c350f26 to
a188b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
providersearch param to wanda's getCatalog call. This is particularly useful in the checks selection view, as we might want to limit the display of checks that can't be applied to certain provider.How was this tested?
Manually by running wanda and checking that the checks selection view causes the search param to be added to the request while the catalog view doesn't.