Remove connection settings when using wanda

[nelsonkopliku]

Description

This keeps only the checks selection when in Wanda context.
As a proposal, page title has also been changed from Cluster Settings for <cluster-name> to Checks Selection for <cluster-name>.

How was this tested?

Added a test case in ChecksSelectionNew.test.jsx

[arbulu89]

I'm a bit lost with the changes.
If the intention is to use the ChecksSelectionNew directly when we go to the settings i wouldn't touch the ClusterSettings code, I would directly render the selection page in the trento.jsx file:

<Route
  path="clusters_new/:clusterID/settings"
  element={<CheckSelectionNew />}
 />

We can even think of changing the path from settings to something else.
The setting component looks like it will be removed soon, so I wouldn't do changes there if possible

[dottorblaster]

I totally agree with the approach @arbulu89 is suggesting, do see any potential issue in that?

[nelsonkopliku]

Alright, I followed the suggestion with the only difference that instead of binding directly CheckSelectionNew to the route, I added an intermediate container Component ClusterSettingsNew for consistency with what we have now (yes we can rethink the structure there) and to keep testing simple.

How does this work?

[dottorblaster]

Much better now! I'm sure the strangling of the old part will be much easier 😅

Some more stuff to take care off then we are ok I think 👍

[arbulu89]

Great job! Thanks @nelsonkopliku

[dottorblaster]

One more change then we are ok to merge 👍

[dottorblaster]

I'd rather export defaultInitialState and then compose it using withState inside the test

[nelsonkopliku]

Initially I started like that and then it looked natural following the same with... pattern, to keep the same level of encapsulation for defaultInitialState, composability and to reduce a bit the boiler of merging the default state with a piece of extra state when needed.
However since you prefer that, I changed as per the suggestion so we can proceed.