Broadcast execution completed #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
dottorblaster,
rtorrero,
CDimonaco,
arbulu89 and
jamie-suse
dottorblaster
suggested changes
Dec 1, 2022
fabriziosestito
force-pushed
the
broadcast-execution-completed
branch
from
1291218 to
ab558cd
Compare
fabriziosestito
force-pushed
the
broadcast-execution-completed
branch
from
ab558cd to
5052cab
Compare
arbulu89
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Looks good @fabriziosestito ,
Let's use the action function instead of importing the action key and creating the payload manually
fabriziosestito
force-pushed
the
broadcast-execution-completed
branch
2 times, most recently
from
faedcf7 to
7cb31b4
Compare
fabriziosestito
force-pushed
the
broadcast-execution-completed
branch
from
7cb31b4 to
e0531e5
Compare
arbulu89
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the updated execution completed action dispatch when the BE receives an execution completed event from wanda.
NOTE:
I had to add the channel and the callback manually and couldn't rely on the
registerEventsutility function since the name of the action and the message sent to the phoenix channel differs.Also, I'd like to use action constants instead of generating the name of the action so I will track a debt to track an improvement on this side.