Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint fix #1016

Merged
merged 23 commits into from
Dec 6, 2022
Merged

Eslint fix #1016

merged 23 commits into from
Dec 6, 2022

Conversation

CDimonaco
Copy link
Member

Description

Reconfigure the eslint linter based on airbnb styleguide with the appropriate linting rules.

This is a first process, hundreds of error will be fixed, but this is a good starting point for further iterations when needed.

We will disable some rules to match our coding standards and our usecases.

How was this tested?

Automated tests still running

@CDimonaco CDimonaco added bug Something isn't working chore javascript Pull requests that update Javascript code labels Nov 28, 2022
@CDimonaco CDimonaco self-assigned this Nov 28, 2022
@CDimonaco CDimonaco marked this pull request as ready for review December 1, 2022 15:46
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanotorresi
Copy link
Member

@dottorblaster dottorblaster merged commit 917146b into main Dec 6, 2022
@dottorblaster dottorblaster deleted the eslint_fix branch December 6, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants