Forbid cleanup of instances in overview pages

trento-project · Jul 2, 2024 · f53662a · f53662a
1 parent 68d85ed
commit f53662a
Show file tree

Hide file tree

Showing 12 changed files with 162 additions and 5 deletions.
diff --git a/assets/js/pages/DatabasesOverview/DatabaseItemOverview.jsx b/assets/js/pages/DatabasesOverview/DatabaseItemOverview.jsx
@@ -4,11 +4,13 @@ import React from 'react';
 import { DATABASE_TYPE } from '@lib/model/sapSystems';
 import InstanceOverview from '@pages/InstanceOverview';
 
-export function DatabaseInstance({ instance, onCleanUpClick }) {
+export function DatabaseInstance({ instance, userAbilities, onCleanUpClick }) {
   return (
     <InstanceOverview
       instanceType={DATABASE_TYPE}
       instance={instance}
+      userAbilities={userAbilities}
+      cleanUpPermittedFor={['cleanup:database_instance']}
       onCleanUpClick={onCleanUpClick}
     />
   );
@@ -27,6 +29,7 @@ const databaseInstanceColumns = [
 function PlainDatabaseItemOverview({
   instances,
   asDatabaseLayer = false,
+  userAbilities,
   onCleanUpClick,
 }) {
   return (
@@ -59,6 +62,7 @@ function PlainDatabaseItemOverview({
                 <DatabaseInstance
                   key={`${instance.host_id}_${instance.instance_number}`}
                   instance={instance}
+                  userAbilities={userAbilities}
                   onCleanUpClick={onCleanUpClick}
                 />
               ))}
@@ -69,21 +73,23 @@ function PlainDatabaseItemOverview({
   );
 }
 
-function DatabaseLayer({ instances, onCleanUpClick }) {
+function DatabaseLayer({ instances, userAbilities, onCleanUpClick }) {
   return (
     <PlainDatabaseItemOverview
       instances={instances}
       asDatabaseLayer
+      userAbilities={userAbilities}
       onCleanUpClick={onCleanUpClick}
     />
   );
 }
 
-function DatabaseInstances({ instances, onCleanUpClick }) {
+function DatabaseInstances({ instances, userAbilities, onCleanUpClick }) {
   return (
     <div className="p-2">
       <PlainDatabaseItemOverview
         instances={instances}
+        userAbilities={userAbilities}
         onCleanUpClick={onCleanUpClick}
       />
     </div>
@@ -93,18 +99,21 @@ function DatabaseInstances({ instances, onCleanUpClick }) {
 function DatabaseItemOverview({
   database,
   asDatabaseLayer = false,
+  userAbilities,
   onCleanUpClick,
 }) {
   const { databaseInstances } = database;
 
   return asDatabaseLayer ? (
     <DatabaseLayer
       instances={databaseInstances}
+      userAbilities={userAbilities}
       onCleanUpClick={onCleanUpClick}
     />
   ) : (
     <DatabaseInstances
       instances={databaseInstances}
+      userAbilities={userAbilities}
       onCleanUpClick={onCleanUpClick}
     />
   );

diff --git a/assets/js/pages/DatabasesOverview/DatabasesOverview.jsx b/assets/js/pages/DatabasesOverview/DatabasesOverview.jsx
@@ -20,6 +20,7 @@ function DatabasesOverview({
   databases,
   databaseInstances,
   loading,
+  userAbilities,
   onTagAdd,
   onTagRemove,
   onInstanceCleanUp,
@@ -116,6 +117,7 @@ function DatabasesOverview({
     collapsibleDetailRenderer: (database) => (
       <DatabaseItemOverview
         database={database}
+        userAbilities={userAbilities}
         onCleanUpClick={(instance, _type) => {
           setCleanUpModalOpen(true);
           setInstanceToDeregister(instance);

diff --git a/assets/js/pages/DatabasesOverview/DatabasesOverview.stories.jsx b/assets/js/pages/DatabasesOverview/DatabasesOverview.stories.jsx
@@ -78,6 +78,10 @@ export default {
         defaultValue: { summary: false },
       },
     },
+    userAbilities: {
+      control: 'array',
+      description: 'Current user abilities',
+    },
     onTagAdd: {
       action: 'Add tag',
       description: 'Called when a new tag is added',
@@ -110,6 +114,7 @@ export const Databases = {
     databases,
     databaseInstances: enrichedInstances,
     loading: false,
+    userAbilities: [{ name: 'all', resource: 'all' }],
   },
 };
 
@@ -118,6 +123,7 @@ export const WithSystemReplication = {
     databases: [databaseWithSR],
     databaseInstances: systemReplicationInstances,
     loading: false,
+    userAbilities: [{ name: 'all', resource: 'all' }],
   },
 };
 
@@ -126,5 +132,13 @@ export const WithAbsentInstances = {
     databases: [databaseWithAbsentInstances],
     databaseInstances: absentInstance,
     loading: false,
+    userAbilities: [{ name: 'all', resource: 'all' }],
+  },
+};
+
+export const UnauthorizedCleanUp = {
+  args: {
+    ...WithAbsentInstances.args,
+    userAbilities: [],
   },
 };
diff --git a/assets/js/pages/DatabasesOverview/DatabasesOverview.test.jsx b/assets/js/pages/DatabasesOverview/DatabasesOverview.test.jsx
@@ -27,6 +27,7 @@ describe('DatabasesOverview component', () => {
         <DatabasesOverview
           databases={[database]}
           databaseInstances={database.database_instances}
+          userAbilities={[{ name: 'all', resource: 'all' }]}
           onInstanceCleanUp={mockedCleanUp}
         />
       );
@@ -47,6 +48,36 @@ describe('DatabasesOverview component', () => {
         database.database_instances[0]
       );
     });
+
+    it('should forbid instance cleanup', async () => {
+      const user = userEvent.setup();
+
+      const database = databaseFactory.build();
+
+      database.database_instances[0].absent_at = faker.date
+        .past()
+        .toISOString();
+
+      renderWithRouter(
+        <DatabasesOverview
+          databases={[database]}
+          databaseInstances={database.database_instances}
+          userAbilities={[]}
+        />
+      );
+
+      const cleanUpButton = screen.getByText('Clean up').closest('button');
+
+      expect(cleanUpButton).toBeDisabled();
+
+      await user.click(cleanUpButton);
+
+      await user.hover(cleanUpButton);
+
+      expect(
+        screen.queryByText('You are not authorized for this action')
+      ).toBeVisible();
+    });
   });
 
   describe('filtering', () => {

diff --git a/assets/js/pages/DatabasesOverview/DatabasesOverviewPage.jsx b/assets/js/pages/DatabasesOverview/DatabasesOverviewPage.jsx
@@ -3,6 +3,7 @@ import React from 'react';
 import { useSelector, useDispatch } from 'react-redux';
 
 import { getEnrichedDatabaseInstances } from '@state/selectors/sapSystem';
+import { getUserProfile } from '@state/selectors/user';
 import {
   addTagToDatabase,
   removeTagFromDatabase,
@@ -27,13 +28,15 @@ function DatabasesOverviewPage() {
   const enrichedDatabaseInstances = useSelector((state) =>
     getEnrichedDatabaseInstances(state)
   );
+  const { abilities } = useSelector(getUserProfile);
   const dispatch = useDispatch();
 
   return (
     <DatabasesOverview
       databases={databases}
       databaseInstances={enrichedDatabaseInstances}
       loading={loading}
+      userAbilities={abilities}
       onTagAdd={(tag, databaseID) => {
         addTag(tag, databaseID);
         dispatch(addTagToDatabase({ tags: [{ value: tag }], id: databaseID }));

diff --git a/assets/js/pages/InstanceOverview/InstanceOverview.jsx b/assets/js/pages/InstanceOverview/InstanceOverview.jsx
@@ -26,6 +26,8 @@ function InstanceOverview({
     absent_at: absentAt,
     deregistering,
   },
+  userAbilities,
+  cleanUpPermittedFor,
   onCleanUpClick,
 }) {
   const isDatabase = DATABASE_TYPE === instanceType;
@@ -77,6 +79,8 @@ function InstanceOverview({
             type="transparent"
             className="jungle-green-500 border-none shadow-none"
             cleaning={deregistering}
+            userAbilities={userAbilities}
+            permittedFor={cleanUpPermittedFor}
             onClick={() => onCleanUpClick(instance, instanceType)}
           />
         </div>

diff --git a/assets/js/pages/InstanceOverview/InstanceOverview.test.jsx b/assets/js/pages/InstanceOverview/InstanceOverview.test.jsx
@@ -57,6 +57,7 @@ describe('InstanceOverview', () => {
       <InstanceOverview
         instanceType={APPLICATION_TYPE}
         instance={absentInstance}
+        userAbilities={[{ name: 'all', resource: 'all' }]}
       />
     );
 
@@ -95,9 +96,38 @@ describe('InstanceOverview', () => {
       <InstanceOverview
         instanceType={DATABASE_TYPE}
         instance={absentInstance}
+        userAbilities={[{ name: 'all', resource: 'all' }]}
       />
     );
 
     expect(screen.getByLabelText('Loading')).toBeInTheDocument();
   });
+
+  it('should forbid instance cleanup', async () => {
+    const user = userEvent.setup();
+
+    const absentInstance = databaseInstanceFactory.build({
+      absent_at: faker.date.past().toISOString(),
+    });
+
+    renderWithRouter(
+      <InstanceOverview
+        instanceType={DATABASE_TYPE}
+        instance={absentInstance}
+        userAbilities={[]}
+      />
+    );
+
+    const cleanUpButton = screen.getByText('Clean up').closest('button');
+
+    expect(cleanUpButton).toBeDisabled();
+
+    await user.click(cleanUpButton);
+
+    await user.hover(cleanUpButton);
+
+    expect(
+      screen.queryByText('You are not authorized for this action')
+    ).toBeVisible();
+  });
 });
diff --git a/assets/js/pages/SapSystemsOverviewPage/SapSystemItemOverview.jsx b/assets/js/pages/SapSystemsOverviewPage/SapSystemItemOverview.jsx
@@ -5,11 +5,13 @@ import { APPLICATION_TYPE } from '@lib/model/sapSystems';
 import DatabaseItemOverview from '@pages/DatabasesOverview/DatabaseItemOverview';
 import InstanceOverview from '@pages/InstanceOverview';
 
-function ApplicationInstance({ instance, onCleanUpClick }) {
+function ApplicationInstance({ instance, userAbilities, onCleanUpClick }) {
   return (
     <InstanceOverview
       instanceType={APPLICATION_TYPE}
       instance={instance}
+      userAbilities={userAbilities}
+      cleanUpPermittedFor={['cleanup:application_instance']}
       onCleanUpClick={onCleanUpClick}
     />
   );
@@ -24,7 +26,7 @@ const applicationInstanceColumns = [
   { key: 'cleanupButton', cssClass: 'w-48' },
 ];
 
-function SapSystemItemOverview({ sapSystem, onCleanUpClick }) {
+function SapSystemItemOverview({ sapSystem, userAbilities, onCleanUpClick }) {
   const { applicationInstances, databaseInstances } = sapSystem;
 
   return (
@@ -56,6 +58,7 @@ function SapSystemItemOverview({ sapSystem, onCleanUpClick }) {
                   <ApplicationInstance
                     key={`${instance.host_id}_${instance.instance_number}`}
                     instance={instance}
+                    userAbilities={userAbilities}
                     onCleanUpClick={onCleanUpClick}
                   />
                 ))}
@@ -66,6 +69,7 @@ function SapSystemItemOverview({ sapSystem, onCleanUpClick }) {
       <DatabaseItemOverview
         database={{ databaseInstances }}
         asDatabaseLayer
+        userAbilities={userAbilities}
         onCleanUpClick={onCleanUpClick}
       />
     </div>

diff --git a/assets/js/pages/SapSystemsOverviewPage/SapSystemsOverview.jsx b/assets/js/pages/SapSystemsOverviewPage/SapSystemsOverview.jsx
@@ -20,6 +20,7 @@ function SapSystemsOverview({
   applicationInstances,
   databaseInstances,
   loading,
+  userAbilities,
   onTagAdd,
   onTagRemove,
   onInstanceCleanUp,
@@ -106,6 +107,7 @@ function SapSystemsOverview({
     collapsibleDetailRenderer: (sapSystem) => (
       <SAPSystemItemOverview
         sapSystem={sapSystem}
+        userAbilities={userAbilities}
         onCleanUpClick={(instance, type) => {
           setCleanUpModalOpen(true);
           setInstanceToDeregister(instance);

diff --git a/assets/js/pages/SapSystemsOverviewPage/SapSystemsOverview.stories.jsx b/assets/js/pages/SapSystemsOverviewPage/SapSystemsOverview.stories.jsx
@@ -82,6 +82,10 @@ export default {
         defaultValue: { summary: false },
       },
     },
+    userAbilities: {
+      control: 'array',
+      description: 'Current user abilities',
+    },
     onTagAdd: {
       action: 'Add tag',
       description: 'Called when a new tag is added',
@@ -115,6 +119,7 @@ export const SapSystems = {
     applicationInstances: enrichedApplicationInstances,
     databaseInstances: enrichedDatabaseInstances,
     loading: false,
+    userAbilities: [{ name: 'all', resource: 'all' }],
   },
 };
 
@@ -124,5 +129,13 @@ export const WithAbsentInstances = {
     applicationInstances: enrichedAbsentApplicationInstances,
     databaseInstances: enrichedAbsentDatabaseInstances,
     loading: false,
+    userAbilities: [{ name: 'all', resource: 'all' }],
+  },
+};
+
+export const UnauthorizedCleanUp = {
+  args: {
+    ...WithAbsentInstances.args,
+    userAbilities: [],
   },
 };