This repository has been archived by the owner on May 30, 2022. It is now read-only.
Exclude diagnostics service sap systems #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
nelsonkopliku
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the SAP diagnostics agent (DAA usually) detection. When this instance is discovered, the projection is skipped, as we don't want to handle this instance type by now. We will see what to do in the future.
The diagnostics agent instance id is computed using the
/etc/machine-idas this sap instance is host specific, it is not a distributed deployment. In this case, the agent id and system id will match. Let me know if you have some better suggestion.The instance type detection has been changed to use the
Featuresfield with regexp, as this field gives exactly the type (some types are part of the application layer).Besides that, I have added some test.
FYI: @abravosuse
PD: I have included a small change in the templating, to unify the SAP instances table headers usage. It is here: 8c3b922
I could remove this commit in any case, but well, it doesn't almost affect. I found it ugly to see when 2 sap systems are discovered, but we won't have this situation often as we won't show diagnostics agents as SAP systems anymore