CI: add job for checking licenses from dependencies #741
Conversation
There was a problem hiding this comment.
Hey @flaviodsr ,
So comments worth checking.
As a side note, if you don't have your golang bin directory in your path the wwhrd execution fails
.wwhrd.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| allowlist: | |||
There was a problem hiding this comment.
Can we rename the file to have yaml extension rather than yml, as we already have files with the 2nd extesion
.github/workflows/ci-cd.yaml
Outdated
| - uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.16 | ||
| - name: Install WWHRD |
There was a problem hiding this comment.
We don't really need to run this in 2 steps, right?
check-licenses already depend on install-wwhrd, so calling the 2nd would call the 1st by default
There was a problem hiding this comment.
you are right, I just thought that in case of failure of the install it would be more clear having a step specifically doing that.
Anyways, I have removed the step.
|
|
||
| .PHONY: install-wwhrd | ||
| install-wwhrd: | ||
| which wwhrd || go install github.com/frapposelli/wwhrd@latest |
There was a problem hiding this comment.
I don't know that much about golang dependencies, but I wonder if there is some option to define this dependency as a development dependency
There was a problem hiding this comment.
I am not aware of such option. Did some research and could not find it either.
There was a problem hiding this comment.
I would ask @fabriziosestito since he is the lord of that pattern but I think we can actually declare wwhrd in the tools/tools.go file having it fetched inside deps
flaviodsr
force-pushed
the
check_licenses
branch
from
0a8a6eb to
fdfec60
Compare
|
@arbulu89 thanks for the review. Regarding the golang bin directory, do you have a suggestion on how to fix that? I could add |
flaviodsr
force-pushed
the
check_licenses
branch
2 times, most recently
from
8e3b3b0 to
8ecdbd4
Compare
The check is implemented using wwhrd [1] and the allowed licenses are listed on the `.wwhrd.yml` file. 1. https://github.com/frapposelli/wwhrd
flaviodsr
force-pushed
the
check_licenses
branch
from
8ecdbd4 to
4c31254
Compare
The check is implemented using wwhrd [1] and the allowed
licenses are listed on the
.wwhrd.ymlfile.Fix: #349