Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Trento server helm chart #206

Merged
merged 7 commits into from
Sep 14, 2021

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Aug 27, 2021

This is an initial implementation of a Trento server helm chart, featuring the web and the runner component.
It also contains an helm chart for the ARA dependency, which uses the official container image.
The official consul helm chart was added as dependency.
For the moment I'm hosting the images on my personal GitHub container registry, we could trigger the image building process from the CI once this has been tested.

The runner component documentation was followed from this PR: #191
A Docker image was built by using the branch from this PR: #189
with the modifications described in this PR: #204
The docker image used in the following example can be found here: https://github.com/users/fabriziosestito/packages/container/trento/6942033?tag=check5

What works:

  • Agents outside kuberentes can connect to the consul server inside kubernetes, this is a scenario provided by the consul helm chart directly
  • Runners and Web components seems to work correctly in a real SAP cluster

Needed improvements:

  • We miss a readyness/live probe for the trento runner component
  • ARA persistence layer as volume or db dependency
  • Docker images built from are CI
  • Curl/bash Installer script that follows the example below (this is WIP)

NOTE: Due to a known regression (k3s-io/k3s#3704) this helm chart does not work with k3s v1.21.3, so make sure to have the latest version of k3s installed.

Install or upgrade k3s

If installing as root:
curl -sfL https://get.k3s.io | sh

If installing as non root user:
curl -sfL https://get.k3s.io | sh -s - --write-kubeconfig-mode 644

Export KUBECONFIG env variable

export KUBECONFIG=/etc/rancher/k3s/k3s.yaml

Install or upgrade helm

curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash

Add hashicorp helm repo

helm repo add hashicorp https://helm.releases.hashicorp.com

helm repo update

Install trento server

cd helm/trento-server/

helm dependency update

helm install trento . --set trento-web.tag="check5" --set trento-runner.tag="check5" --set-file trento-runner.privateKey=id_rsa_runner

Copy link
Member

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In relation to #212 (review) , we should probably move this stuff into packaging/helm or something like that.

Other than this, this looks very good!

Keep up the good work and, as mentioned previously, try to consolidate the installation script with the one related to the Agent component so that we provide complementary entry-points that are consistent with each other as far as the UX goes.

Comment on lines 1 to 15
Trento Server installed!
_ _ _ _ _ _ _ _
| |_| |_| | | |_| |_| |
\ . / \ . . /
\ , / \ . /
| . |_ _ _ _ _ _| , |
| .| |_| |_| |_| |_| |_| | . |
| , | . . . . | .|
| . | . . . . , |. |
___----_____| . |. , _______ . | , |---~_____
_---~ | | . /+++++++\ . | . | ~---_
|. | . |+++++++| . | . | ~-_
__ | . | , |+++++++|. . _|__ | ~-_
____--`~ '--~~__ . |++++ __|----~ ~`---, ___^~-__
-~--~ ~---__|,--~' ~~----_____-~' `~----~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahah I love this!!!

@fabriziosestito
Copy link
Member Author

In relation to #212 (review) , we should probably move this stuff into packaging/helm or something like that.

Other than this, this looks very good!

Keep up the good work and, as mentioned previously, try to consolidate the installation script with the one related to the Agent component so that we provide complementary entry-points that are consistent with each other as far as the UX goes.

@stefanotorresi thanks for the feedbacks, I will move forward in this direction and try to provide a script for the installation.

One thing I am still missing would be the containers registry. Should we use the trento organization github registry or should we move in the OBS direction? If we choose the latter, I would need some support with obs.

@stefanotorresi
Copy link
Member

stefanotorresi commented Sep 14, 2021

Should we use the trento organization github registry [...]?

Yes. :)
We'll use SUSE's Build Service later.

@fabriziosestito fabriziosestito marked this pull request as ready for review September 14, 2021 09:22
Copy link
Member

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's packaging, not packages 😉

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Stefano Torresi <[email protected]>
@stefanotorresi stefanotorresi merged commit 7fa6157 into trento-project:main Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants