Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsisten vendoring issue due the self replace #73

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

arbulu89
Copy link
Contributor

Fix for in go1.18 during the make build action:

go: inconsistent vendoring in /home/xarbulu/Workspace/sap_squad/trento-stack/runner:
	github.com/trento-project/runner: is marked as replaced in vendor/modules.txt, but not replaced in go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
make: *** [Makefile:45: trento-runner] Error 1

Some related external discussions:
containerd/containerd#6586
golang/go#34417

Apparently the self replace thing is not supported anymore in golang 1.18, since it doesn't make many sense.
@stefanotorresi Could you have a special look on this, since I don't really know why we started having this thing in the code

@arbulu89 arbulu89 added the bug Something isn't working label Jun 14, 2022
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI is happy I'm happy as well

@stefanotorresi
Copy link
Member

I think that line was originally in the monolithic repo. If removing it doesn't break anything, go with it.

@arbulu89 arbulu89 force-pushed the fix-inconsistent-vendoring branch from 4811415 to 30ae2e6 Compare June 15, 2022 06:41
@arbulu89 arbulu89 merged commit 3001729 into trento-project:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants