Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include suse container packaging #57

Merged

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented May 2, 2022

Include suse packaging files for the runner container. It enables the CI to push to OBS as well (and in a while, we would mirror this container in IBS).

The major particularity of the Dockerfile is that depending on the premium-checks.tar.gz file is present or not in the OBS package, It will add these files to the container or not.

By now, it will ship the container in: https://build.opensuse.org/package/show/devel:sap:trento:factory/trento-runner-image

The last commit includes a fix for the git CVE-2022-24765. More info in:
https://github.blog/2022-04-12-git-security-vulnerability-announced/
actions/checkout#760

@arbulu89 arbulu89 force-pushed the include-suse-container-packaging branch 7 times, most recently from ecdfdf6 to 425f794 Compare May 3, 2022 08:53
@arbulu89 arbulu89 added the enhancement New feature or request label May 3, 2022
@arbulu89 arbulu89 marked this pull request as ready for review May 3, 2022 09:09
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@arbulu89 arbulu89 marked this pull request as draft May 3, 2022 13:40
@arbulu89 arbulu89 force-pushed the include-suse-container-packaging branch 2 times, most recently from de8fc5b to 0455418 Compare May 4, 2022 07:49
@arbulu89 arbulu89 force-pushed the include-suse-container-packaging branch from 0455418 to 08dea40 Compare May 4, 2022 07:53
@arbulu89 arbulu89 marked this pull request as ready for review May 4, 2022 07:54
@arbulu89 arbulu89 force-pushed the include-suse-container-packaging branch from 08dea40 to 4e38940 Compare May 4, 2022 08:02
@arbulu89 arbulu89 merged commit ba1d07f into trento-project:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants