Pass json list in quotes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi,
nelsonkopliku and
abravosuse
nelsonkopliku
approved these changes
Apr 28, 2022
fmherschel
pushed a commit
to fmherschel/runner
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cluster_selected_checkswas not being set totally correct, as it was not a list. In order to pass as a real json, we need to use quotes.For reference: https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#json-string-format
This way, the value is set as
["check_id", "check_id"], as a list of stringsOtherwise is set as
"[check_id, check_id]", as a string instead of a list