Set failed check executions as critical #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi,
nelsonkopliku and
abravosuse
abravosuse
approved these changes
Apr 27, 2022
fmherschel
pushed a commit
to fmherschel/runner
that referenced
this pull request
Apr 28, 2022
* Disable check result overwritting * Set abnormally failed tasks to critical * Update python binary path in Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due the way ansible handle callbacks, the code was overwriting some check results, when the ansible task was failing abnormally (for example, when the checked file in some checks don't exist).
This change disables the overwritting.
Besides that, I have changed the check result to a
criticalstate in this case, rather thanwarning, as it looks something worth checking. What do you think @abravosuse ?By now, we don't display the error message in the frontend, but in this cases we send it to the server, so at some point we could show it.