Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move used strucs on the factsengine to a entities package #90

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Sep 2, 2022

Create a new entities package within factsengine to structure better the code and align with the new contracts repository entities. They still continue mirroring the contracts struct, but this are for internal consumption. Once they are done, they don't even need to have any json annotation, as they are not for messaging purposes.

  • The facts_gathered file structs follow the same pattern than the contract (facts_gathered_v1.go
  • The facts_gathering_request file structs are still the old ones, as the contract is not totally defined yet. Once it is, this must be changed

Besides that, a lot of copy/pasting and renaming

@arbulu89 arbulu89 merged commit 5aa7afa into main Sep 6, 2022
@stefanotorresi stefanotorresi deleted the move-facts-engine-structs-entities branch October 3, 2022 11:07
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants