Move used strucs on the factsengine to a entities package #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
entities
package within factsengine to structure better the code and align with the new contracts repository entities. They still continue mirroring the contracts struct, but this are for internal consumption. Once they are done, they don't even need to have any json annotation, as they are not for messaging purposes.facts_gathered
file structs follow the same pattern than the contract (facts_gathered_v1.gofacts_gathering_request
file structs are still the old ones, as the contract is not totally defined yet. Once it is, this must be changedBesides that, a lot of copy/pasting and renaming