Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gathered facts using contract #88

Merged
merged 5 commits into from
Sep 2, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Sep 2, 2022

First interaction with the contracts repository to publish the gathered facts.

Basically, it uses the contracts project to build the answer.

I have introduced the policy.go file to make it as similar as the wanda side (followed the old PR: #73). The facts gathering request logic will go in this file as well.

Some next step:

  • Create a entities package within the factsengine to store the used structs (now in facts.go). We need to align the structs there with the ones defined in the contracts, following similar naming convention, fields, etc
  • Unify naming conventions and rabbitmq usage values, like exchange names, queues, etc
  • Do the same operation with the facts gathering request message, which is consumed by the agent. Pending to define the format of this message yet.

@arbulu89 arbulu89 added the enhancement New feature or request label Sep 2, 2022
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 merged commit 26eecc4 into main Sep 2, 2022
@stefanotorresi stefanotorresi deleted the publish-gathered-facts-using-contract branch October 3, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants