Change trento-premium to be obsolete in the spec #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
requested review from
dottorblaster,
arbulu89,
CDimonaco,
fabriziosestito,
nelsonkopliku and
stefanotorresi
nelsonkopliku
approved these changes
Jul 11, 2022
ajaeger
reviewed
Jul 11, 2022
rtorrero
force-pushed
the
obsolete-old-package
branch
from
c867117 to
fc711c4
Compare
rtorrero
commented
Jul 11, 2022
| @@ -33,7 +33,9 @@ BuildRequires: golang(API) = 1.16 | |||
| Requires: golang-github-prometheus-node_exporter | |||
| Provides: %{name} = %{version}-%{release} | |||
| Provides: trento = %{version}-%{release} | |||
| Provides: trento-premium = %{version}-%{release} | |||
| Obsoletes: trento < %{version}-%{release} | |||
There was a problem hiding this comment.
Now that I think about this, I suspect we should have probably not used the macro here to fix the (deprecated) provided version to an specific version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply changes the relationship in the spec file with the old
trento-premiumpackage so that it's now marked as Obsolete. This should reduce the possibility of users installing the older package without noticing that it has been obsoleted.