-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update agent to golang 1.22 #344
Conversation
2bbeebc
to
1f94f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be fine as long as CI is happy 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad the CI is stopping you but still green light from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to update the RPM build requirement here:
agent/packaging/suse/trento-agent.spec
Line 31 in 5208bcb
BuildRequires: golang(API) = 1.18 |
@stefanotorresi I updated the build requirement in the previous commits, your link refer to another branch or something similar, if you take a look at the change the buildrequires is set to 1.22 |
uh okay, sorry, I totally didn't see it in the list of changes :D |
This PR updates the agent code/building infrastructure to be built with golang 1.22.