Send sbd data in diskless scenario #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cluster discovery part to allow sending SBD data in diskless scenario.
In this case, even if the cluster doesn't have any SBD resource, the cluster can be running a SBD diskless fencing type.
The code removes that conditions. It will still print an error message is something goes wrong during SBD discovery and the SBD resource is configured. The code won't crash anymore, as not having SBD is not critical always, and the web part handles all this scenarios. Better to send the payload in any case.
I have removed some unused code as well.
The rationales:
SBD diskless consists on having SBD configured and running, but without any SBD device or resource.
If somebody wants to read further: https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-storage-protect.html#sec-ha-storage-protect-diskless-sbd