Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor collector package tests #288

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Refactor collector package tests #288

merged 2 commits into from
Nov 20, 2023

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Nov 2, 2023

Refactor collector package tests

EMaksy
EMaksy reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@arbulu89 arbulu89 merged commit 9db3a3d into main Nov 20, 2023
9 checks passed
@arbulu89 arbulu89 deleted the refactor-collector-package-tests branch November 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMaksy EMaksy EMaksy left review comments

@CDimonaco CDimonaco CDimonaco approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
tech debt test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arbulu89 @nelsonkopliku @CDimonaco @EMaksy