Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gatherers package tests #286

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Refactor gatherers package tests #286

merged 2 commits into from
Nov 16, 2023

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Nov 2, 2023

Refactor gatherers package tests to follow the package_test convention.
In this case, we did a good job, since only the corosyncconf and verifypassword packages had a wrong usage.

@arbulu89 arbulu89 changed the title Refactor verifypassword tests Refactor gatherers package tests Nov 2, 2023
@arbulu89 arbulu89 marked this pull request as ready for review November 2, 2023 08:44
@arbulu89 arbulu89 merged commit 2ec901a into main Nov 16, 2023
9 checks passed
@arbulu89 arbulu89 deleted the refactor-gatherers-package-tests branch November 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMaksy EMaksy EMaksy approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees
No one assigned
Labels
tech debt test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arbulu89 @nelsonkopliku @EMaksy