Add os-release gatherer #283
Conversation
rtorrero
force-pushed
the
os-release-gatherer
branch
from
247a1c2 to
f24d3bb
Compare
| log.Error(err) | ||
| return facts, OSReleaseFileError.Wrap(err.Error()) | ||
| } | ||
| defer file.Close() |
There was a problem hiding this comment.
Let's puts some logs in this defer. Just in case.
As we do in: https://github.com/trento-project/agent/blob/main/internal/factsengine/gatherers/groups.go#L61
| return facts, nil | ||
| } | ||
|
|
||
| func mapToFactValue(inputMap map[string]string) entities.FactValue { |
There was a problem hiding this comment.
Rename this to mapOSReleaseToFactValue or similar.
Keep in mind that this function is shared across all the package, and it looks too generic
| @@ -0,0 +1,12 @@ | |||
| NAME="Ubuntu" | |||
| VERSION="20.04.3 LTS (Focal Fossa)" | |||
| ID=ubuntu | |||
There was a problem hiding this comment.
I have always seen values wrapped in quotes. Does ubuntu have them without?
It would be nicer to put opensuse 🙈
There was a problem hiding this comment.
The quotes are not mandatory AFAIK, see some examples: https://manpages.ubuntu.com/manpages/focal/man5/os-release.5.html
I think they are only required when they include values with spaces in them.
I've added some openSUSE love in the mocked data :-)
This PR adds a new gatherer for the /etc/os-release file. It will take all the values present in the file and export them as a map.