Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use google protobuf value in Fact message #120

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Use google protobuf value in Fact message #120

merged 3 commits into from
Oct 18, 2022

Conversation

fabriziosestito
Copy link
Member

No description provided.

arbulu89
arbulu89 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as an 1:1 translation.
We would still need to send struct and list types, as we might start relaying in more complex test expression.
It can come in a future PR.
We should track it though

go.mod Outdated Show resolved Hide resolved
@fabriziosestito fabriziosestito force-pushed the use_google_protobuf_value branch from 456ee8c to 80c3d70 Compare October 18, 2022 10:15
@fabriziosestito fabriziosestito force-pushed the use_google_protobuf_value branch from 616ae06 to ae2827d Compare October 18, 2022 11:01
@fabriziosestito fabriziosestito merged commit 11e8cb9 into main Oct 18, 2022
@fabriziosestito fabriziosestito deleted the use_google_protobuf_value branch October 18, 2022 12:15
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziosestito @arbulu89 @nelsonkopliku