Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinement in the main README #101

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Refinement in the main README #101

merged 1 commit into from
Sep 21, 2022

Conversation

mpagot
Copy link
Contributor

@mpagot mpagot commented Sep 21, 2022

Fix some typo
Update some .yam variable names

@mpagot
Refinement in the main README
a4ab588 
Fix some typo
Update some .yam variable names
@mpagot mpagot mentioned this pull request Sep 21, 2022
Closed
arbulu89
arbulu89 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpagot
PD: You didn't need to open a new PR, simply amend the last one or add a new commit.

README.md
@@ -157,7 +156,8 @@ systemctl start trento-agent.service
```

> If the discovery loop is being executed too frequently, and this impacts the Web interface performance, the agent
> has the option to configure the discovery loop mechanism using the various `--<cloud,cluster,host,sapsystem>-discovery-period` flags. Increasing these value improves the overall performance of the application
> has the option to configure the discovery loop mechanism using the various `--<cloud,cluster,host,sapsystem>-discovery-period` flags.
> Increasing this value improves the overall performance of the application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preferred the these values option, but well, so be it XD

@arbulu89 arbulu89 merged commit cba022c into trento-project:main Sep 21, 2022
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpagot @arbulu89 @nelsonkopliku