Update moment.js to resolve regex DoS vulnerability #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSP is alerting on a vulnerability introduced by the moment.js dependency: https://nodesecurity.io/advisories/532 See the upstream issue resolved by the update: moment/moment#4163
mdholloway
changed the title
|
Can we look into this PR, this is an optional dependency, nevertheless it would be good to update the dependencies to its latest version, especially, when there is a security vulnerability. |
|
Thank you very much. Apologies for the delay. (FYI on the delay in my responding: #335 (comment)) |
|
I also merged this to the 1.x branch in commit 990426d |
trentm
pushed a commit
that referenced
this pull request
Jun 29, 2020
CVE-2017-18214 https://nodesecurity.io/advisories/532 See the upstream issue resolved by the update: moment/moment#4163
|
[email protected] and [email protected] (beta) have been published with this (yes, I realize years late :/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSP is alerting on a vulnerability introduced by the moment.js dependency:
https://nodesecurity.io/advisories/532
See the upstream issue resolved by the update:
moment/moment#4163