Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Travis CI integration #422

Merged
merged 2 commits into from
Mar 4, 2017
Merged

Added Travis CI integration #422

merged 2 commits into from
Mar 4, 2017

Conversation

Srokap
Copy link
Contributor

@Srokap Srokap commented Jul 10, 2016

Fixes #342

For sample builds, see https://travis-ci.org/Srokap/node-bunyan/builds

There seems to be some random failures on osx that go away on reruns, they look like that:

> make test
test -z "1" || test -n "" || \
        (node -e 'require("dtrace-provider").createDTraceProvider("isthisthingon")' && \
        echo "\nNote: Use 'SKIP_DTRACE=1 make test' to skip parts of the test suite that require root." && \
        sudo ./node_modules/.bin/nodeunit test/dtrace.test.js)
Note: Use 'SKIP_DTRACE=1 make test' to skip parts of the test suite that require root.
dtrace.test.js
✔ basic dtrace
✖ bunyan -p
AssertionError: 20 == 10
    at Object.equal (/Users/travis/build/Srokap/node-bunyan/node_modules/nodeunit/lib/types.js:83:39)
    at ChildProcess.<anonymous> (/Users/travis/build/Srokap/node-bunyan/test/dtrace.test.js:108:15)
    at ChildProcess.emit (events.js:110:17)
    at Process.ChildProcess._handle.onexit (child_process.js:1078:12)
AssertionError: 'hi at debug' == 'hi at trace'
    at Object.equal (/Users/travis/build/Srokap/node-bunyan/node_modules/nodeunit/lib/types.js:83:39)
    at ChildProcess.<anonymous> (/Users/travis/build/Srokap/node-bunyan/test/dtrace.test.js:109:15)
    at ChildProcess.emit (events.js:110:17)
    at Process.ChildProcess._handle.onexit (child_process.js:1078:12)
FAILURES: 2/11 assertions failed (4468ms)
make: *** [test] Error 1
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.
Done. Your build exited with 1.

Copy link
Contributor

@twhiteman twhiteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this would be useful, though needs a couple of tweaks.

.travis.yml Outdated
- '4'
- '5'
- 'node'
- 'iojs'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be good, though a couple of suggestions:

  • remove 'iojs'
  • add node 6 and 7
  • add SKIP_DTRACE=1 environment variable

@Srokap
Copy link
Contributor Author

Srokap commented Mar 2, 2017

Updated. Needed t rebase on current master branch for it to stop failing on node 7. I left node entry instead of 7 as those are pointing to same version. If node 8 branches off as stable, we'll need to update the list. Passes all versions on Linux, currently OSX builds are pending, need to make sure https://travis-ci.org/Srokap/node-bunyan/builds/206856505 passed before merging just to be safe.

@Srokap
Copy link
Contributor Author

Srokap commented Mar 2, 2017

@twhiteman PTAL

@twhiteman
Copy link
Contributor

All looks good to me, @trentm please merge and add GitHub Travis CI hook, or hook me up and I'll do it :)

@trentm trentm merged commit 4a500c4 into trentm:master Mar 4, 2017
@trentm
Copy link
Owner

trentm commented Mar 4, 2017

Yah, I think that is working: https://travis-ci.org/trentm/node-bunyan/builds/207566856

@Srokap Thanks very much!

@Srokap Srokap deleted the travis branch March 7, 2017 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants