-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Travis CI integration #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think this would be useful, though needs a couple of tweaks.
.travis.yml
Outdated
- '4' | ||
- '5' | ||
- 'node' | ||
- 'iojs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be good, though a couple of suggestions:
- remove 'iojs'
- add node 6 and 7
- add SKIP_DTRACE=1 environment variable
Updated. Needed t rebase on current master branch for it to stop failing on node 7. I left |
@twhiteman PTAL |
All looks good to me, @trentm please merge and add GitHub Travis CI hook, or hook me up and I'll do it :) |
Yah, I think that is working: https://travis-ci.org/trentm/node-bunyan/builds/207566856 @Srokap Thanks very much! |
Fixes #342
For sample builds, see https://travis-ci.org/Srokap/node-bunyan/builds
There seems to be some random failures on osx that go away on reruns, they look like that: