E2E upload object test #8631
Merged
E2E upload object test #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarYuran
added
the
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
idanovo
requested changes
Feb 10, 2025
Comment on lines
13
to
17
| test("Create repo", async ({page}) => { | ||
| const repositoriesPage = new RepositoriesPage(page); | ||
| await repositoriesPage.goto(); | ||
| await repositoriesPage.createRepository(TEST_REPO_NAME, true); | ||
| }); |
There was a problem hiding this comment.
The create repository should be a step in the same test, the upload file test shouldn't test the create repository step
|
|
||
| const repositoryPage = new RepositoryPage(page); | ||
| await repositoryPage.uploadObject(filePath); | ||
| await expect(page.getByRole('complementary')).toContainText(`lakefs://${TEST_REPO_NAME}/main/${FILE_NAME}`); |
There was a problem hiding this comment.
Let's add a check that we can see the new file at the right path.
idanovo
reviewed
Feb 10, 2025
Comment on lines
128
to
132
| async uploadObject(filePath: string): Promise<void> { | ||
| await this.page.getByRole("button", { name: "Upload Object" }).click(); | ||
| await this.page.getByText("Drag 'n' drop files or").click(); | ||
| const fileInput = await this.page.locator('input[type="file"]'); | ||
| await fileInput.setInputFiles(filePath); |
There was a problem hiding this comment.
Suggested change
| async uploadObject(filePath: string): Promise<void> { | |
| await this.page.getByRole("button", { name: "Upload Object" }).click(); | |
| await this.page.getByText("Drag 'n' drop files or").click(); | |
| const fileInput = await this.page.locator('input[type="file"]'); | |
| await fileInput.setInputFiles(filePath); | |
| async uploadObject(filePath: string): Promise<void> { | |
| await this.page.getByRole("button", { name: "Upload Object" }).click(); | |
| await this.page.getByText("Drag 'n' drop files or").click(); | |
| const fileInput = await this.page.locator('input[type="file"]'); | |
| await fileInput.setInputFiles(filePath); |
N-o-Z
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8542